[PATCH] Fix XKB options passed from HAL

[Paulo Cesar Pereira de Andrade]

Daniel Stone wrote:
> On Mon, Dec 03, 2007 at 01:40:45PM -0200, Paulo Cesar Pereira de Andrade wrote:
>   
>>   But I believe the code in config/hal.c needs some more rework. It
>> must be compatible with xorg.conf, or refuse to load if xorg.conf
>> specifies a conflicting input device, and hal should work with the
>> kbd and mouse drivers, otherwise, if it only works with evdev, there
>> is no point in all the configuration code.
>>     
>
> Again, this isn't config/hal.c, this is hw/xfree86.
> NewInputDeviceRequest should just walk the config tree and DTRT,
> potentially calling down into the drivers to ask, 'are you handling
> this?'.  This is why NIDR exists.
>
> Cheers,
> Daniel
>   

  This maybe a bit late (or too early if one changes the code to
load hal specified devices before xorg.conf ones). And expecting
NewInputDeviceRequest to fix the fact that hal devices cannot map
to xorg.conf devices may be too much to ask.

  IMO the proper fix is to match the xorg.conf input device
section with the hal section (don't ask me how to do it, I don't
know, that's why I filled the bug report
https://bugs.freedesktop.org/show_bug.cgi?id=13361),
if the xorg.conf code and hal code coexist in the X Server, and
"one doesn't know about the other" and both load one module to
handle the same input device, things are unlikely to work properly.
And the EVIOCGRAB ioctl should not be a justification to have
2 different modules handling the same device. It works with
evdev, but the mouse driver, as I reported earlier will generate
duplicated events, and mixing evdev with kbd and mouse is wrong.

Paulo