[PATCH] Fix XKB options passed from HAL

[Paulo Cesar Pereira de Andrade]

Daniel Stone wrote:
> On Sun, Dec 02, 2007 at 05:00:00PM +0100, Brice Goglin wrote:
>   
>> Kanru Chen sent the attached patch to fix the XKB options that are
>> passed to the server from HAL. Without this, he gets
>>     (**) Option "xkb_options" ","
>>
>> I guess we need such a fix in master and 1.4.1.
>>
>> Full details available at the beginning of
>>     http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453683
>>     
>
> Thanks a bunch (and apologies for being so monumentally dumb: it's not
> only wrong, but quite obviously so by inspection alone).  I've merged
> this to master and 1.4 branch.
>   
  It is fine, we still love you :-)

  But I believe the code in config/hal.c needs some more rework. It
must be compatible with xorg.conf, or refuse to load if xorg.conf
specifies a conflicting input device, and hal should work with the
kbd and mouse drivers, otherwise, if it only works with evdev, there
is no point in all the configuration code.

  Maybe the code should just "pass" the hal options to the driver. I.e.
instead of expecting a option named xkb_options of type string list,
just  use this code to all string_list properties. This has the advantage
that the code in hal/config.c doesn't need to be update if an option
changes type (or is incorrectly configured like the xkb_layout option
that should be a string_list) and hal options could change type/name
easily (unless there are configuration tools depending on values there),
and only the input driver would need to actually "parse" the option
value.
  If the input driver has, and will use the normal XF86Options, you
could also check if the XF86Option matches the hal option type/name.

>
> Cheers,
> Daniel
>   

Paulo