[PATCH] Use autocofigured package version if possible. Update the module version to the autoconfigured one.

Daniel Stone daniel at fooishbar.org
Wed Apr 25 00:21:25 PDT 2007


On Wed, Apr 25, 2007 at 03:14:42AM +0200, Giuseppe Bilotta wrote:
> On 4/25/07, Alan Coopersmith <alan.coopersmith at sun.com> wrote:
> >Daniel Stone wrote:
> >> On Wed, Apr 25, 2007 at 03:06:26AM +0200, Giuseppe Bilotta wrote:
> >>>  #ifdef HAVE_CONFIG_H
> >>>  #include "config.h"
> >>> +#else
> >>> +#define PACKAGE_VERSION_MAJOR 1
> >>> +#define PACKAGE_VERSION_MINOR 2
> >>> +#define PACKAGE_VERSION_PATCHLEVEL 0
> >>>  #endif
> >>
> >> When could HAVE_CONFIG_H possibly be unset?
> >
> >Now that we are no longer sharing source with the monolith, should
> >all the #ifdef HAVE_CONFIG_H's be removed and just always include
> >config.h now?
> 
> If this is the case, a sweeping change removing the #ifdef
> HAVE_CONFIG_H *and* setting the module version to
> PACKAGE_VERSION_MAJOR, ... in every module is probably the way to go.

Yep.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20070425/37835f6f/attachment.pgp>


More information about the xorg mailing list