[PATCH 1/3] Initial support for device autodetection.

Daniel Stone daniel at fooishbar.org
Wed Apr 25 00:20:57 PDT 2007


On Wed, Apr 25, 2007 at 02:44:05AM +0200, Giuseppe Bilotta wrote:
> +static Bool
> +fd_query_acecad(int fd) {
> +	char name[256] = "Unknown";
> +	char ace_name[7] = "ACECAD\0";

You don't need the trailing \0.

> +    for (i = 0; ; i++) {
> +	char fname[64];
> +	int fd = -1;
> +	Bool is_acecad;
> +
> +	sprintf(fname, "%s/%s%d", DEV_INPUT_EVENT, EVENT_DEV_NAME, i);

You want to use snprintf here.

> +    ErrorF("%s no acecad event device found (checked %d nodes)\n",
> +	   local->name, i + 1);

xf86Msg instead?

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20070425/3d16f9e9/attachment.pgp>


More information about the xorg mailing list