Xserver config dbus interface introspection

Nicolas "Ikke" Trangez eikke at eikke.com
Sat Apr 14 11:33:15 PDT 2007

On Sat, 2007-04-14 at 04:19 +0200, Nicolas "Ikke" Trangez wrote:
> On Fri, 2007-04-13 at 13:46 -0700, Alan Coopersmith wrote:
> > Just a nit - in config/config-introspection-data.h you left Keith's
> > name throughout the license - while I'm sure he disclaims warranty on
> > code you wrote, it's usually preferred to put a generic term such as
> > "the copyright holders", or at least your name in there.
> Heh, sorry... Copied the header from another sourcefile, didn't notice
> that part. Will fix.
> Daniel: I defined it in another header because it's somewhat easier to
> edit, I'll merge it in config.c. I might make the string a static global
> too, initing it in the module init function and freeing in the module
> close function, so the snprintf isn't necessary on every introspection
> call. The size calculation of the malloc needs some more work too,
> hard-defining it is bad, its just strlen(THE_DEFINE) +
> strlen(atoi(display)).

Updated patch attached, please review.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-config-introspection2.patch
Type: text/x-patch
Size: 9018 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20070414/fb5cf82d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070414/fb5cf82d/attachment.pgp>

More information about the xorg mailing list