[RFC] libdri changes for single-entity multi-screen DRI.

Eric Anholt eric at anholt.net
Wed Apr 4 10:03:42 PDT 2007

On Wed, 2007-04-04 at 13:57 +0200, Thomas Hellström wrote:
> Hi!
> I'd like to commit the attached patch before the xserver-1.3 release.
> It may break DRI drivers that depend on DRM lastclose to do their 
> cleanup, so it would be good to have some feedback
> on this.

At this point in the release cycle, I feel adding a feature wouldn't be
appropriate unless required by the release plan, especially when it
hasn't even been in master yet.  However, the 1.4 release is coming up
in a month or so, so you're not that far from getting it pushed out if
you push it to master.

> /Thomas
> plain text document attachment
> (0001-Changes-for-single-entity-multi-screen-DRI.txt)
> >From 6c5b2664c9f26833d4d5543ff59dfe1c697b2d64 Mon Sep 17 00:00:00 2001
> From: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>
> Date: Wed, 4 Apr 2007 13:52:18 +0200
> Subject: [PATCH] Changes for single-entity-multi-screen DRI.
> The entity has a screen-common SAREA that contains the hardware lock.
> In addition, each screen creates a new sarea, but screen 0 has the
> option to reuse the entity sarea. This is the default and should make the
> change backwards compatible.
> The master DRI file descriptor will be common for all screens and will not
> be closed between server generations.
> DRI drivers that depend on DRM to do cleanup in "lastclose" between
> server generations will not work as intended.
> The DRI fd will only be closed when the X server exits.
> Signed-off-by: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>

That said, assuming that DRM drivers exist that need lastclose between
server generations, being ready for that is something that should be
indicated from the DRM drivers using the DI versioning system, rather
than having X assume they'll just work and fall over.

Eric Anholt                             anholt at FreeBSD.org
eric at anholt.net                         eric.anholt at intel.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070404/aae0b216/attachment.pgp>

More information about the xorg mailing list