xserver: Branch 'master' - 12 commits

Daniel Stone daniel at fooishbar.org
Thu Sep 28 14:54:35 PDT 2006


On Thu, Sep 28, 2006 at 01:33:55PM -0700, Aaron Plattner wrote:
> [the wfb commit]
>
> [...]
>
> +#define MEMCPY_WRAPPED(dst, src, size) do {                       \
> +    size_t _i;                                                    \
> +    CARD8 *_dst = (CARD8*)(dst), *_src = (CARD8*)(src);           \
> +    for(_i = 0; _i < size; _i++) {                                \
> +        WRITE(_dst +_i, READ(_src + _i));                         \
> +    }                                                             \
> +} while(0)
>
> [...]
>
>   * by reading/writing aligned CARD32s where it's easy
>   */
> [...]
>  	    /* Do four aligned pixels at a time */
> [and so on, and so forth]

This is evidently no longer the case.  Could you please modify this to
do aligned accesses where possible?  Doing unaligned really hurts us on
architectures like ARM, where the cycles expended on unaligned accesses
are actually important, unlike i386/amd64, where it doesn't particularly
matter much.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20060929/7cbacdcc/attachment.pgp>


More information about the xorg mailing list