keithp's randr patch for xserver

[Drew Parsons]

In Debian bug #291100 [1], Keith Packard is quoted as identifying a
patch for randr in xserver, to address an endianness issue.  He is
quoted in January 2005 as saying

> heh.  Looks like there's a byteswapping bug in XRandR.  Nice catch.
> 
> Note that the erroneous value (0x100) is a byteswapped short from the
> valid value (0x1).  Then note that the value isn't byteswapped in the X
> server.
> 
> Index: randr.c
> ===================================================================
> RCS file: /cvs/xserver/xserver/randr/randr.c,v
> retrieving revision 1.21
> diff -u -r1.21 randr.c
> --- randr.c     11 Sep 2003 05:12:51 -0000      1.21
> +++ randr.c     20 Jan 2005 04:39:01 -0000
> @@ -1072,6 +1072,7 @@
> 
>      swaps(&stuff->length, n);
>      swapl(&stuff->window, n);
> +    swaps(&stuff->enable, n);
>      return ProcRRSelectInput(client);
>  }


Now this patch does not seem to have been applied. The line in question
is now at l.1189, but the second swaps is still not there.

Should it have been applied or was there a reason for leaving it out?

Drew

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=291100