xserver: Branch 'master' - 2 commits

Alan Hourihane alanh at fairlite.demon.co.uk
Tue Nov 21 11:22:24 PST 2006


On Sat, 2006-11-18 at 23:01 +0200, Daniel Stone wrote:
> On Sat, Nov 18, 2006 at 11:57:09AM -0800, Alan Hourihane wrote:
> >     Shutdown input devices if FatalError occurs during startup.
> >     Fixes Xdmx problems when the input device has been initialized
> >     and the keyboard map has been destroyed.
> 
> Hi Alan,
> Could you please elaborate on which problem this actually fixes?
> (Particularly as Xdmx doesn't even build currently.)  It's quite ugly,
> and presumably implies that FatalError/AbortDDX isn't doing its job of
> bringing the server down correctly.

Any server that initialises the keyboard and does anything funky with it
(as Xdmx does) via InitAndStartDevices() and then a FatalError occurs
(say because of a bad fontpath), the keyboard (as well as other input
devices) don't get cleaned up because they never get called with
DEVICE_OFF/DEVICE_CLOSE.

If there's some cleaner way, please go ahead.

Alan.




More information about the xorg mailing list