NetBSD and xserver and core dump and no drivers

[Daniel Stone]

On Thu, May 25, 2006 at 03:26:21PM -0700, Jeremy C. Reed wrote:
> > #7  0x080af313 in fixup_video_driver_list (drivers=0x0) at 
> > xf86Config.c:461
> > #8  0x080af499 in GenerateDriverlist (dirname=0x818721f "drivers", 
> >     drivernames=0x81a87c8 "") at xf86Config.c:514
> 
> May I commit the following? With this Xorg closes cleanly and the logs 
> have: "Missing output drivers.  Configuration failed."
> 
> --- ./hw/xfree86/common/xf86Config.c    7 Apr 2006 01:41:00 -0000       1.28
> +++ ./hw/xfree86/common/xf86Config.c    25 May 2006 22:13:29 -0000
> @@ -510,7 +510,7 @@
>      ret = LoaderListDirs(subdirs, patlist);
>      
>      /* fix up the probe order for video drivers */
> -    if (strstr(dirname, "drivers"))
> +    if (strstr(dirname, "drivers") && ret != NULL)
>          fixup_video_driver_list(ret);
>  
>      return ret;

I guess fixing fixup_video_driver_list to handle a NULL argument would
be cleaner, and avoid this problem in other places, so feel free to
commit that.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20060526/44a46815/attachment.pgp>