PCI rework

[Daniel Stone]

On Tue, May 02, 2006 at 03:16:52PM +0200, John Hughes wrote:
> Ian Romanick wrote:
> > Mark Kettenis wrote:
> >
> > How do you figure?  The interface is modeled after the interface in
> > libpci (part of pciutils), which was created long before the sysfs
> 
> ^^ notice correct use of parens, space before "(", after ")"
> 
> > interface was available, and has been ported to other platforms.  There
> > was quite a bit of discussion about this some months ago (in February).
> 
> ^^ again.
> 
> >
> > >-    *pucByte = pciReadByte(pMga->PciTag,ulOffset);
> > >+    pci_device_cfg_read_u8( pMga->PciInfo, pucByte, ulOffset );
> >
> >
> > >Oh, and I really think you shouldn't change the coding style.  Those
> > >extra spaces after the the '(' are just plain ugly ;-).
> >
> >
> > Yeah,beingabletoactuallyreadthecodeissuchahorriblething. :P
> 
> 
> No, to make the code readable follow the typographical conventions that
> have been used for decades, if not centuries.

Coding style wars are incredibly dumb.  Ian's agreed to follow the style
of any code he patches, AFAICT (a sensible policy), so let's all just
move on, and not bother trolling with coding style/editor wars.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20060502/d67935e8/attachment.pgp>