Changing the way drivers find DRI headers

[Michel Dänzer]

On Fri, 2006-06-16 at 08:31 -0700, Donnie Berkholz wrote:
> Tilman Sauerbeck wrote:
> > Donnie Berkholz [2006-06-16 08:05]:
> >> Tilman Sauerbeck wrote:
> >>> Tilman Sauerbeck [2006-04-25 17:29]:
> >>>> Why are these checks even needed?
> >>>>
> >>>> I think it should be enough to call
> >>>> PKG_CHECK_MODULES(DRI, xf86driproto libdrm, have_dri=yes, have_dri=no)
> >>> Won't work of course if the server was configured with --disable-dri :)
> >>>
> >>> Maybe it's best to add another variable to xorg-server.pc:
> >>> have_dri=yes/no
> >> I like this idea. Right now we've got hacks in our build system to
> >> ensure the server's +dri if drivers are getting built +dri, etc.
> > 
> > On IRC, Michel pointed out that the server might have been build without
> > DRI support, but you still could want to build the drivers with the DRI
> > enabled.
> 
> Good luck doing that -- have you tried? It doesn't work.

I'll take your word for it. :)

Today I discovered that --disable-dri in the driver is a no-op because
xorg-server.h defines XF86DRI* anyway. So I'm thinking maybe the drivers
shouldn't bother with defining them but just require the other
prerequisites when xorg-server.h defines them. Or is there a scenario
where --disable-dri is required even though the server was built with
DRI support? (I'm finding it quicker to #undef XF86DRI in config.h for
build testing)


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer