[PATCH] fbcmap.c -> xf86 DDX

Enrico Weigelt weigelt at metux.de
Tue Jun 6 03:58:13 PDT 2006


* Adam Jackson <ajax at nwnk.net> schrieb:

<snip>

> I already explained this to you:
> 
> http://lists.freedesktop.org/archives/xorg-modular/2006-May/001083.html
> 
> fbcmap.c should not be DDX-dependent.  That it is, is a bug, and we're not 
> going to fix it by splitting the file up, because that's the wrong solution.  
> The correct solution is to fix the code to do consistent colormap handling 
> for all DDXes.

Okay, but when will it be ? Within this century ?

As you already pointed out, these #ifdef's are really smell.
And I'm gonna clean it up. And I'm doing that now, not in 10 years.

If you've got the new colormap handling, put in the cirle, but
please don't try to stop me from doing smaller cleanups, just 
because they are not perfect enough. 

I suggest going in small steps continously instead of spending 
years for trying giant jumps.


cu
-- 
---------------------------------------------------------------------
 Enrico Weigelt    ==   metux IT service - http://www.metux.de/
---------------------------------------------------------------------
 Please visit the OpenSource QM Taskforce:
 	http://wiki.metux.de/public/OpenSource_QM_Taskforce
 Patches / Fixes for a lot dozens of packages in dozens of versions:
	http://patches.metux.de/
---------------------------------------------------------------------



More information about the xorg mailing list