[PATCH] new radeon memory map fixes

[Michel Dänzer]

On Sat, 2006-01-28 at 03:22 +1100, Benjamin Herrenschmidt wrote:
> 
> > Also, unless I'm missing something, you're removing the code that forces
> > the display priority to high for Radeon 7200.
> 
> Oops ? Where did I miss that ? (which bit of code specifically ? If it's
> the hack that was in SetFBLocation, it's now in the bandwidth calc)

I mean

    /* old AIW Radeon has some BIOS initialization problem
     * with display buffer underflow, only occurs to DFP
     */
    if (!info->HasCRTC2)
	OUTREG(RADEON_GRPH_BUFFER_CNTL,
	       INREG(RADEON_GRPH_BUFFER_CNTL) & ~0x7f0000);

from RADEONRestoreFPRegisters().


> > > http://gate.crashing.org/~benh/radeon-memmap-drm-3.diff
> > 
> > The way you handle backwards compatibility here is brilliant, thanks.
> > The only minor issue I see is that the setparam ioctl can be called by
> > unprivileged clients, but that applies to the existing colour tiling
> > part as well, and it may not be a problem thanks to the offset fixups.
> 
> I'm not 100% sure yet of whta the clients may or may not do here, I'd be
> very happy if you could double check that part :)

I can't think of any case that this patch wouldn't cover offhand.


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer