[patch] XVideo on my Radeon

[Roland Scheidegger]

Benjamin Herrenschmidt wrote:
>> I'm not sure what this specific change exactly should do, it does not 
>> really seem to match the cvs log ("Fix bug in Radeon connector table 
>> parsing -- parse all entries, not just the first." - at least by just 
>> looking at the code it seems feasible that the old code would parse the 
>> 2nd entry when the first one would be empty where the new code wouldn't, 
>> though since the new code uses a 16bit value instead of an 8bit one I'm 
>> not sure this interpretation is correct, as I've no idea how those bios 
>> tables really are supposed to look like).
> 
> I did that change... The spec says the table is termined with 0x0000 and
> testing only 8 bits makes the code stop parsing before the end as some
> valid entries can start with 0x00 (I had actual examples of that).
Judging by the log of the OP, this seems exactly such a case too.
(II) RADEON(0): Connector0: DDCType-2, DACType-0, TMDSType-0, 
ConnectorType-4
(II) RADEON(0): Connector1: DDCType-3, DACType-0, TMDSType--1, 
ConnectorType-2
The second one would map to 0 on the first 8 bits, at least the DACType 
and TMDSType bits were both 0 (and the latter got caught in the sanity 
checks), (unless there would be other bits not decoded).

> However, I don't know about the i > 1 thing. I assumed it was a hack to
> workaround the former bug, it didn't make much sense based on the spec.
> However the spec also provides a connector count so maybe I should test
> that too.
I guess that's unnecessary then and you're correct it was just a hack.

> In any way, I don't know for sure what's up with Xv, unless we end up
> flipping CRTC1 and 2 but I'm not sure how/why that would have happened.

(II) RADEON(0): Primary:
  Monitor   -- CRT
  Connector -- DVI-D
  DAC Type  -- Primary
  TMDS Type -- Internal
  DDC Type  -- DVI_DDC
(II) RADEON(0): Secondary:
  Monitor   -- CRT
  Connector -- VGA
  DAC Type  -- Primary
  TMDS Type -- NONE
  DDC Type  -- VGA_DDC

I'd bet that did look differently without that change, though it's not 
my kettle of fish. Alex knows this stuff a lot better than I do, so 
you'd better follow his advice :-).

Roland