[PATCH] Accelerated two directional blt support for EXA

[Adam Jackson]

On Saturday 25 February 2006 17:08, Jesse Barnes wrote:
> Since my lame Trident Cyberblade only supports blts in two directions
> (xdir == ydir), this patch is needed to get decent blt acceleration on
> my machine.  I just took the equivalent XAA code and ported it over to
> EXA.  Seems to work ok on my machine, but I'd appreciate review and/or
> comments.  One thing that's lacking is proper error handling for the
> new case.  If one of the PrepareCopy calls fails, I'm not sure what to
> do, since we may be part way through the CopyNtoN process...
>
> Thoughts?

I can't think of a case where you'd ever fail part-way through the blit, so I 
don't think that case matters too much.  But failing on the first PrepareCopy 
is certainly possible, in which case 'goto fallback' is correct.

Also, maybe split the lame code into a static function for readability?  The 
fallback nearly doubles the size of exaCopyNtoN which is otherwise quite 
readable.

+1.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20060227/42d0b506/attachment.pgp>