[PATCH] Clean up XEvIE damage in dix/events.c

Stuart Kreitman Stuart.Kreitman at Sun.COM
Thu Aug 17 11:13:10 PDT 2006


Looks fine to me. Derek is a great programmer, if a little verbose.

Stuart

Daniel Stone wrote:
> Hi,
> This patch fixes a bunch of XEvIE detritus in dix/events.c by changing:
> #ifdef XEVIE
> xeviehot.x =
> #endif
> sprite.hot.x = ...
> 
> #ifdef XEVIE
> xeviehot.y =
> #endif
> sprite.hot.y = ...
> 
> ad nauseum to:
> #ifdef XEVIE
> xeviehot.x = sprite.hot.x;
> xeviehot.y = sprite.hot.y;
> #endif
> 
> once at the end.  The only functional change I can see is that
> xeviehot.[xy] will be subject to the same ConfineToShape call that
> sprite.hot.[xy] is if sprite.hotShape is set.  I don't see any reason
> why this shouldn't be done (though my XEvIE knowledge is very minimal),
> so I assume it was more a case of not matching grep more than anything.
> 
> XEvIE people, ACK/NAK?
> 
> Cheers,
> Daniel
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg



More information about the xorg mailing list