Patch for compiling SiS statically

Thomas Winischhofer thomas at winischhofer.net
Fri Oct 28 11:56:20 PDT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthias Hopf wrote:
> On Oct 28, 05 19:25:11 +0200, Thomas Winischhofer wrote:
> 
>>>the following patch is needed to compile the SiS driver (and anything
>>>potentially using setjmp/longjmp) statically.
>>>
>>>If noone objects, I'll commit the code at the beginning of the next week.
>>>
>>>Matthias
>>
>>I basically don't object, but nevertheless am surprised that noone has
>>noticed this before. Is the SiS driver really the only one using
>>setjmp/longjmp?
> 
> 
> Yes. It's just the module loader in xf86cfg/loader.c that needs setjmp
> as well. And that file includes <setjmp.h> itself. I'm a bit surprised
> by that.
> 
> I already talked with Egbert, he has the opinion that using setjmp is
> wrong in the first place, because it gives you headaches on some
> architectures (don't know whether SiS is a valid gfx hardware on these,
> though).


If you look at the file you will see that it is not. It's only used on
x86/32 and AMD64.

Thomas

- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          http://www.winischhofer.net/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDYnRUzydIRAktyUcRAuH7AKChlf+57qtLk48adBQ8Rqu713l1IACgl/US
9i29RG0piOX/hGb39Xlsaak=
=/29s
-----END PGP SIGNATURE-----



More information about the xorg mailing list