CVS Update: xc (branch: trunk)

[Felix Kühling]

Am Dienstag, den 01.02.2005, 07:20 -0500 schrieb Mike A. Harris:
> On Tue, 1 Feb 2005, Felix Kühling wrote:
> 
> >>   The Radeon (and other?) drivers used to have 
> >> a "ForcePCIMode" option used for the exact same purpose that 
> >> you're indicating you're using it for, and it was renamed to be 
> >> BusType in newer radeon driver code to be consistent with other 
> >> drivers and to generically handle different bustypes.
> >
> >True. But do I need such a generic option in a driver that is never
> >going to need it. Maybe a generic option looks nice to you and me, but
> >makes things more confusing for users. For example it wouldn't make
> >sense to set BusType to AGP on PCI hardware. But a user may be tempted
> >to think that this option enables him to magically upgrade his PCI card
> >to an AGP card. My point is that an option name and semantics should be
> >chosen such that it clearly indicates what you can and can't do with it.
> >ForcePCIMode does that.
> 
> I think consistency is more important myself, but that's just me.

I kind of invalidated my own argument by introducing Option DmaType. For
consistencies sake I should either change DmaType to ForcePCIDma or
change ForcePCIMode into BusType. If the BusType option is the preferred
way to go then I'll do the latter.

> 
[snip]

-- 
| Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
| PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |