[PATCH] EXA support for i830 (for real this time!)
Jesse Barnes
jbarnes at virtuousgeek.org
Wed Aug 31 10:45:41 PDT 2005
On Wednesday, August 31, 2005 1:51 am, Alan Hourihane wrote:
> Another problem with your patch is the use of I830_USE_XAA and
> I830_USE_EXA where you should really be using pI830->useEXA.
>
> Think of the case that both I830_USE_XAA and I830_USE_EXA are defined.
> There are places which reference XAA's AccelInfoRec that will blow up
> when EXA is in use, yet the driver has been compiled with support for
> both.
I've been running with both enabled and have tested with both
AccelMethod=XAA and AccelMethod=EXA and both work. I haven't
tested !I830_USE_EXA && I830_USE_XAA recently though.
> It's probably easier to completely remove the I830_USE_EXA and
> I830_USE_XAA defines and use pI830->useEXA completely to avoid
> confusion.
Sure, I'll go double check everything.
Jesse
More information about the xorg
mailing list