SiS driver fails to build (patch included)

Thomas Winischhofer thomas at winischhofer.net
Thu Aug 11 05:44:51 PDT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthias Hopf wrote:
> Hi,
> 
> the SiS driver currently fails to build due to a missing
> #include <setjmp.h>. It also redefines BUFSIZ (from stdio) with an own,
> personal, buffer size - without ever using it.

What are you talking about? BUFSIZ is used at several places all over
sis_memcpy.c.

And I never saw any problem with setjmp.h either.... what platform/os
are you compiling on, and with what compiler?

> 
> The applied patch fixes both.
> 
> CU all
> 
> Matthias
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: programs/Xserver/hw/xfree86/drivers/sis/sis_memcpy.c
> ===================================================================
> RCS file: /cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/sis/sis_memcpy.c,v
> retrieving revision 1.19
> diff -u -p -r1.19 sis_memcpy.c
> --- programs/Xserver/hw/xfree86/drivers/sis/sis_memcpy.c	11 Jul 2005 02:29:59 -0000	1.19
> +++ programs/Xserver/hw/xfree86/drivers/sis/sis_memcpy.c	11 Aug 2005 09:32:18 -0000
> @@ -32,6 +32,7 @@
>  #endif
>  
>  #include "sis.h"
> +#include <setjmp.h>
>  
>  #if 0			/* Debug */
>  #define SISDGBMC
> @@ -41,7 +42,6 @@ extern unsigned int SISAllocateFBMemory(
>  extern void	    SISFreeFBMemory(ScrnInfoPtr pScrn, void **handle);
>  
>  #define CPUBUFSIZE 2048      /* Size of /proc/cpuinfo buffer */
> -#define BUFSIZ (576 * 1152)  /* Matches 720x576 YUV420 */
>  
>  /************************************************************************/
>  /*                   arch specific memcpy() routines                    */
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg


- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net	       *** http://www.winischhofer.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFC+0hCzydIRAktyUcRAkSYAJoD7wsO6jVeFR8usYcGOqdjnXaBKQCfUmDo
RjPG9vriJBcGdwvKD55qmo4=
=icqO
-----END PGP SIGNATURE-----



More information about the xorg mailing list