Radeon TV-in support in Xorg CVS.

Vladimir Dergachev volodya at mindspring.com
Sun Oct 3 07:49:30 PDT 2004


>>       overlay windows)
>>
>
> There are a couple of compile failures with gcc 3.4.2:
> radeon_video.c:2112: error: label at end of compound statement
> fi1236.c fails to compile because of missing prototype for
> MT2032_dump_status().
>
> Please apply attached (trivial) patch.

Fixed. Thank you !

>
> Also I have to say the sources in drivers/i2c are virtually unreadable -
> parts are without ANY indentation and whitespace while the rest is not
> using any consistent indentation or whitespace scheme. Please fix this
> while the code is still fresh.

No identation ? I guess I've been looking so long at these that I can't 
tell. The only thing that I see is that fi1236.c has two different 
identation styles - XFree86 and my own, I'll fix that when I get a chance.

Otherwise, please let me know if anything else is amiss..

                       best

                          Vladimir Dergachev

PS On second thought, are you using Emacs ? Set your tabs to 8 spaces - 
this is what my editor (Nedit) uses.

>
> -- 
> Ronny V. Vindenes <s864 at ii.uib.no>
>



More information about the xorg mailing list