Daniel's X11R6.8.x approval requests / was: Re: [Bug 1896] libX11 support for pt_BR

Roland Mainz roland.mainz at nrubsig.org
Tue Nov 30 13:28:08 PST 2004


Daniel Stone wrote:
> > Erm... which patches are that (except those from Daniel Stone - which
> > seems to miss more or less all requirements needed to obtain approval
> > for X1R6.8.x (and yes, I am ANGRY about this misuse of the approval flag
> > system)) - could you please make a list ? Until now I thought all
> > patches which are approved for X11R6.8.x are commited to "trunk", too
> > (this applies AFAIK to all of my patches and most of the patches I can
> > think about).
> 
> There's now 19 bugs with 30 attachments pending review and commit and
> whatever without any flags at all, and I strongly suggest their
> inclusion in 6.8.x.
> 
> I'm not doing anything with them or filing further bugs because it makes
> you angry.  Tell me how to work without making you angry and I'll do
> what I can to get them in and included in a way that doesn't kill you.

My point is/was that the "approval"-flag just has the meaning that
someone is requesting approval to get a patch into the "stable" branch
(=X11R6.8.x branch). The term "stable" means in this case: The patch
should be a known-to-be-good patch, e.g. something which is in trunk
since some time and caused no trouble there or obvious fixes (e.g. typo
fixes etc.). The "approval" flag is NOT a way to request review for a
patch. The approval flag system was added to help release-wranglers to
coordinate things in a better way than the previously used bug
dependicies [1].
The part which made me slightly upset is that you didn't even stop
requesting approval for (untested) patches which weren't commited to
Xorg CVS trunk even after I emailed you about it and added even a
comment in bugzilla... the whole stuff looked more like a DOS-attack
against the approval queue than usefull work... ;-(

[1]=(in your case (e.g. the UBUNTU bugs) I would simply suggest to
create a "tracker" bug and mark all bugs with patches from UBUNTU as
blockers for that tracker bug. And then make the tracker bug for UBUNTU
as blocker for the release tracker bug)

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)



More information about the xorg mailing list