[Xorg] MGA patches

[Eric Anholt]

On Wed, 2004-07-21 at 12:31, Ryan Underwood wrote:
> Hi,
> 
> I have two patches in the XFree86 bug tracker which seem to be meeting
> with disinterest on the "other side".  I was wondering if anyone over
> here had any comments or would like to merge them.  I'm getting a little
> tired of hand applying them to my systems.
> 
> http://bugs.xfree86.org/show_bug.cgi?id=1401
> 
> This is a simple patch which corrects the following misbehavior.  If a
> dualhead configuration is used in XF86Config, but dualhead is actually
> disabled for some reason (usually due to an error during initialization
> of the second head), then any video activity will immediately segfault
> the server in MGASwapContextShared.  Well, if dualhead isn't actually
> being used, then there is no pointer to the second screen, so we should
> use MGASwapContext instead.

If this gets in our bugzilla, I'll commit it soon, if someone else
doesn't (the queue of patches in my tree is pretty large already).

> http://bugs.xfree86.org/show_bug.cgi?id=1098
> 
> This patch is more comprehensive, and adds support for the G-series
> Maven chip.  Through the Maven, it enables DDC and DPMS on the second
> head of a G400 as well as TV cable detection.  This is the first steps
> towards removing the dependency on the mga HAL library; from here we
> will have to figure out how to do mode setup through the Maven chip, but
> the current features seem compelling enough to me to request it to be
> included as-is.
> 
> I've been running both these patches on my system for at least a month
> without any problems.  However, I seem to have some problems getting
> other people to test them.

This is pretty exciting.  What concerns do you have about this code at
this point?  Would any testing on a G400 singlehead help, and if so is
there any specific testing you would want done?

-- 
Eric Anholt                                eta at lclark.edu          
http://people.freebsd.org/~anholt/         anholt at FreeBSD.org