libshadow + fb fix

Jim Gettys jg at laptop.org
Wed May 24 06:41:46 PDT 2006


Daniel,

Please be more gentle with people on mailing lists....

I know it gets frustrating at times, but we want a friendly environment
for newbies.
                         Best Regards,
                             - Jim


On Wed, 2006-05-24 at 09:20 +0100, Daniel Stone wrote:
> On Tue, May 23, 2006 at 08:59:20PM +0200, Enrico Weigelt wrote:
> > * Adam Jackson <ajax at nwnk.net> wrote:
> > > On Wednesday 17 May 2006 10:39, Enrico Weigelt wrote:
> > > > This fix adds some (non-compiled) file from libfd to libshadow,
> > > > so the misssing symbols can be resolved.
> > > 
> > > Absolutely not.
> > > 
> > > Notice the big chunks of fbcmap.c under conditional compilation.  
> > > It has to be compiled once per DDX to match the #defines for each one.
> > 
> > hmm, so it has to be added to the individual DDX'es instead of libfb ?
> 
> DUDE, THIS IS WHAT IS DONE ALREADY.
> 
> > AFAICS there are exactly two cases in fbcmap.c: 
> > a) XFree86Server is defined
> > b) -''- not defined
> > 
> > So we could easily split it off into two files and add just the right
> > file to the individual DDX'es.
> 
> Yes, if you were sufficiently bored, but that would mean still more
> duplication for the meantime, so no.
> 
> > Could anyone give me an hint, why and when XFree86Server exactly
> > is defined ?
> 
> grep XFree86Server configure.ac $(find ./ -type f -name Makefile.am)
> 
> Again, can you *please* actually look at what's going on before you ask
> questions?  It's quicker for all of us, and doesn't make you look quite
> so stupid on publicly-archived mailing lists.
> _______________________________________________
> xorg-modular mailing list
> xorg-modular at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-modular
-- 
Jim Gettys
One Laptop Per Child




More information about the xorg-modular mailing list