Build fails when using BuildRoot

[Stefan Dirsch]

On Tue, Jun 28, 2005 at 07:14:42AM -0400, Owen Taylor wrote:
> 
> 
> On Tue, 2005-06-28 at 11:48 +0200, Stefan Dirsch wrote:
> > On Tue, Jun 28, 2005 at 10:55:18AM +0200, Stefan Dirsch wrote:
> > > Xaw build fails when using BuildRoot (current CVS).
> > > 
> > > make[3]: Entering directory `/usr/src/packages/BUILD/xorg-modular/lib/Xaw'
> > > cd /usr/lib && rm -f libXaw.so && ln -s libXaw8.so libXaw.so
> > > ln: creating symbolic link `libXaw.so' to `libXaw8.so': Permission denied
> > > make[3]: *** [install-exec-hook] Error 1
> > > 
> > > The symlink should be made in $RPM_BUILD_ROOT/usr/lib instead of
> > > /usr/lib.  Since I'm still not very familiar with autotool I currently
> > > cannot provide a patch. Sorry for this. Probably lib/Xaw/Makefile.am
> > > needs to be changed accordingly ...
> > 
> > At least the attached patch works for me ...
> 
>  install-exec-hook:
> -       cd $(libdir) && rm -f libXaw.so && ln -s $(DEFAULT_LIB) libXaw.so
> +       cd $(DESTDIR)/$(libdir) && rm -f libXaw.so && ln -s $(DEFAULT_LIB) libXaw.so
> 
> You actually want $(DESTDIR)$(libdir) ... $(libdir) already starts with
> a '/'

And $(DESTDIR) ends with a '/'. It shouldn't matter much, if you now
have one or two '/' to much. Anyway, I would be happy when your
version would be applied to CVS. Looks like my patch is not that wrong
...

Regards,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
------------------------------------------------------