Warning fixes

[Stefan Dirsch]

On Sat, Jul 30, 2005 at 01:03:20PM -0700, Alan Coopersmith wrote:
> Stefan Dirsch wrote:
> >Since CVS access has not been granted by sitewranglers at freedesktop yet
> >(#3873), I attach my current patch again.
> 
> Thanks - hopefully they'll get to that soon.   I've gone ahead and committed
> most of these.   

Thanks a *lot* for looking at these and commiting most of them!

> A couple of notes on the others:
> 
> >--- app/xedit/lisp/write.c.orig	2005-07-18 09:32:53.000000000 +0000
> >+++ app/xedit/lisp/write.c	2005-07-18 09:33:31.000000000 +0000
> >+#include <stdio.h>
> >--- app/xedit/lisp/require.c.orig	2005-07-18 09:35:33.000000000 +0000
> >+++ app/xedit/lisp/require.c	2005-07-18 09:35:44.000000000 +0000
> >@@ -29,6 +29,7 @@
> >+#include <stdio.h>
> > --- app/xedit/lisp/core.c.orig	2005-07-18 09:46:09.000000000 +0000
> > +++ app/xedit/lisp/core.c	2005-07-18 09:47:27.000000000 +0000
> > +#include <stdio.h>
> 
> In both my monolith and modular builds, all of these already get stdio.h via
> xedit/lisp/private.h, so if you're not getting it that way, I suspect 
> there's
> something more seriously wrong with your builds than missing stdio.h 
> headers.

For whatever reasons these patches are no longer required.

> >--- app/luit/sys.c.orig	2005-07-25 14:07:00.000000000 +0000
> >+++ app/luit/sys.c	2005-07-25 14:08:49.000000000 +0000
> >@@ -21,6 +21,7 @@
> > */
> > /* $XFree86: xc/programs/luit/sys.c,v 1.9 2003/08/17 20:39:58 dawes Exp $ 
> > */
> > 
> >+#define _XOPEN_SOURCE
> > #include <stdlib.h>
> > #include <string.h>
> > #include <stdio.h>
> 
> Hardcoding _XOPEN_SOURCE defines breaks other platforms.   If needed, it 
> should be done only in for the platforms that need it in configure.ac (see
> the many examples already scattered around the modular builds of this.)

Thanks. A new patch for this is attached.

Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
------------------------------------------------------
-------------- next part --------------
--- app/luit/configure.ac.orig	2005-07-30 23:06:28.000000000 +0000
+++ app/luit/configure.ac	2005-07-30 23:10:54.000000000 +0000
@@ -30,11 +30,23 @@
 
 AC_PROG_CC
 AC_PROG_INSTALL
+AC_CANONICAL_HOST
 
 AC_CHECK_LIB(z, gzopen,, AC_MSG_ERROR([zlib not found]))
 
 # Checks for pkg-config packages
 PKG_CHECK_MODULES(LUIT, x11 fontenc)
+
+case $host_os in
+    linux*)
+        OS_CFLAGS="-D_XOPEN_SOURCE"
+        ;;
+    *)
+        OS_CFLAGS=
+        ;;
+esac
+
+LUIT_CFLAGS="$LUIT_CFLAGS $OS_CFLAGS"
 AC_SUBST(LUIT_CFLAGS)
 AC_SUBST(LUIT_LIBS)