[PATCH][1/1] - Xserver - XTrap prep sources for config.h inclusion

GOMBAS Gabor gombasg at sztaki.hu
Tue Apr 19 07:14:35 PDT 2005


On Tue, Apr 19, 2005 at 11:10:38PM +1000, Daniel Stone wrote:

> I never said it was a good idea.  But the likelihood of someone else's
> config.h defining XFree86LOADER, _SYNC_SERVER, or such, is rather low.

Well, _not_ defining them if an Xorg header depends on them can be just
as bad. And <config.h> contains much more, so somebody might be tempted
to use "#ifdef HAVE_FOO_H" or similar which is much more likely to
conflict with other projects.

And <config.h> defines some generic macros like PACKAGE_NAME, so two
different <config.h>s from two different projects will _always_
conflict.

Gabor

-- 
     ---------------------------------------------------------
     MTA SZTAKI Computer and Automation Research Institute
                Hungarian Academy of Sciences
     ---------------------------------------------------------


More information about the xorg-modular mailing list