[PATCH][1/1] - Xserver - XTrap prep sources for config.h inclusion

[GOMBAS Gabor]

On Mon, Apr 18, 2005 at 11:11:53PM -0700, John Davidorff Pell wrote:

> Also, I personally don't like using config.h because ... Well, it  
> just makes me uncomfortable. I always think that something is going  
> to go wrong, or an old config.h is going to get included, or even the  
> wrong one, maybe one will get installed in /usr/include which would  
> be *crazy* hard to debug at some point in the future on another build  
> of some totally unrelated package, &c &c. I also think that there  
> really shouldn't be *that* many #defines that there are so many that  
> adding them to the command line is impractical. $0.02.

Automake sets the first '-I' option to point to the directory of
config.h so you actually have to work hard to use a wrong config.h. If
you try to #include two different config.h files you will get a lot of
warnings about redefined macros so you'll surely notice it.

I don't know how many #defines there will be but for a project of this
size my guess would be in the order of 100; 100 '-D' switches would make
command lines practically unreadable.

IMHO.

Gabor

-- 
     ---------------------------------------------------------
     MTA SZTAKI Computer and Automation Research Institute
                Hungarian Academy of Sciences
     ---------------------------------------------------------