[PATCH][1/1] - Xserver - XTrap prep sources for config.h inclusion

[Daniel Stone]

On Tue, Apr 19, 2005 at 12:20:18AM -0700, John Davidorff Pell wrote:
> On 18 Apr 2005, at 23:20, Daniel Stone wrote:
> >On Mon, Apr 18, 2005 at 11:11:53PM -0700, John Davidorff Pell wrote:
> >>Wow! You're really putting in some great effort here. :-D
> >>
> >>A couple comments for you:
> >>
> >>I noticed that you have included config.h in a few header files. I
> >>assume that this was just a mistake, so I thought I'd just make sure
> >>you realised it. :-)
> >
> >... why would it be a mistake?  Given that config.h, in autotools,
> >defines everything.
> 
> You included it in a *header* file, which I didn't think is good to  
> do... Am I wrong? Other packages would then include that header file,  
> inheriting your config.h reference. Shouldn't config.h just be  
> included at the top of relevant (all?) source files? :-)

Depends if they're internal or external headers.  But even if they're
external, it'd be unlikely to do any harm.  That being said, it's not
the best of ideas that you should do it unless you need to.

> >>Also, I personally don't like using config.h because ... Well, it
> >>just makes me uncomfortable. I always think that something is going
> >>to go wrong, or an old config.h is going to get included, or even the
> >>wrong one, maybe one will get installed in /usr/include which would
> >>be *crazy* hard to debug at some point in the future on another build
> >>of some totally unrelated package, &c &c. I also think that there
> >>really shouldn't be *that* many #defines that there are so many that
> >>adding them to the command line is impractical. $0.02.
> >
> >If someone installs config.h in /usr/include, they need to be smacked
> >about the head until nirvana is achieved through total  
> >unconsciousness.
> 
> I agree, I'm just saying that it makes me nervous! ;-)

Trust me, the resultant $(CC) invocations really are that big.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.x.org/archives/xorg-modular/attachments/20050419/ff3de8c4/attachment.pgp