[PATCH][1/1] - Xserver - XTrap prep sources for config.h inclusion

[John Davidorff Pell]

Wow! You're really putting in some great effort here. :-D

A couple comments for you:

I noticed that you have included config.h in a few header files. I  
assume that this was just a mistake, so I thought I'd just make sure  
you realised it. :-)

Also, I personally don't like using config.h because ... Well, it  
just makes me uncomfortable. I always think that something is going  
to go wrong, or an old config.h is going to get included, or even the  
wrong one, maybe one will get installed in /usr/include which would  
be *crazy* hard to debug at some point in the future on another build  
of some totally unrelated package, &c &c. I also think that there  
really shouldn't be *that* many #defines that there are so many that  
adding them to the command line is impractical. $0.02.

JP



On 18 Apr 2005, at 20:57, Shawn Starr wrote:

> Prep some of the sources to include config.h for other #defines  
> that may be
> set by the autotools.
>
>