[Xorg-driver-geode] cppcheck results for xf86-video-geode

[Martin-Éric Racine]

Greetings,

Seeing today's news about a 23 year old security issue having been found
in Xserver's codebase, I thought that I would run the same tool against
xf86-video-geode's codebase. 

$ cppcheck --force --enable=warning,performance,portability . 2>err.txt

The result is attached.

Martin-Éric
-------------- next part --------------
[src/z4l.c:1657]: (error) Memory leak: dp
[src/cim/cim_vip.c:1278] -> [src/cim/cim_vip.c:1281]: (warning) Possible null pointer dereference: buffer - otherwise it is redundant to check it against null.
[src/cim/cim_vip.c:220] -> [src/cim/cim_vip.c:222]: (warning) Possible null pointer dereference: buffer - otherwise it is redundant to check it against null.
[src/gfx/i2c_acc.c:285]: (warning) Assignment of function parameter has no effect outside the function.
[src/gx_video.c:855]: (warning) Assignment of function parameter has no effect outside the function.
[src/lx_video.c:417]: (warning) Assignment of function parameter has no effect outside the function.
[src/gfx/gfx_init.c:444] -> [src/gfx/gfx_init.c:447]: (performance) Variable 'value' is reassigned a value before the old one has been used.
[src/gfx/init_gu1.c:40] -> [src/gfx/init_gu1.c:48]: (performance) Variable 'value' is reassigned a value before the old one has been used.
[src/gx_driver.c:882] -> [src/gx_driver.c:891]: (performance) Variable 'ret' is reassigned a value before the old one has been used.
[src/gx_vga.c:178] -> [src/gx_vga.c:180]: (performance) Variable 'tmp' is reassigned a value before the old one has been used.
[src/lx_exa.c:1041] -> [src/lx_exa.c:1055]: (performance) Variable 'opPtr' is reassigned a value before the old one has been used.
[src/lx_exa.c:1043] -> [src/lx_exa.c:1057]: (performance) Variable 'apply' is reassigned a value before the old one has been used.
[src/lx_memory.c:149] -> [src/lx_memory.c:150]: (performance) Variable 'offset' is reassigned a value before the old one has been used.
[src/panel/cen9211.c:569] -> [src/panel/cen9211.c:570]: (performance) Variable 'PanelType' is reassigned a value before the old one has been used.
[src/panel/cen9211.c:593] -> [src/panel/cen9211.c:594]: (performance) Variable 'PanelType' is reassigned a value before the old one has been used.
[src/panel/dora9211.c:284] -> [src/panel/dora9211.c:285]: (performance) Variable 'value' is reassigned a value before the old one has been used.
[src/panel/dora9211.c:285] -> [src/panel/dora9211.c:286]: (performance) Variable 'value' is reassigned a value before the old one has been used.
[src/panel/dora9211.c:286] -> [src/panel/dora9211.c:287]: (performance) Variable 'value' is reassigned a value before the old one has been used.
[src/panel/dora9211.c:74] -> [src/panel/dora9211.c:76]: (performance) Variable 'DPanelType' is reassigned a value before the old one has been used.