[Xorg-driver-geode] [PATCH 12/12] Remove unused and misleading I386ARCH configuration code

Martin-Éric Racine martin-eric.racine at iki.fi
Fri Nov 18 06:40:17 PST 2011


Ideally, this would instead be converted into something that sets the
path to i386 headers and libraries, and switches the compiling host to
use its 32-bit personality, so that the driver can be cross-compiled
on 64-bit x86 hosts.

2011/11/17 Gaetan Nadon <memsize at videotron.ca>:
> The AM_CONDITIONAL I386ARCH is not used.
>
> The AC_CHECK_DECLS is misleading as it suggests there could be some i*86
> system with a 64 bit architecture which is incorrect.
> It also provides false results on 64 bit computer.
>
> The generated HAVE_DECL_XXX are not used anyway.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |   15 ---------------
>  1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index ec4f87e..179fd28 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -114,21 +114,6 @@ AC_SUBST([XORG_CFLAGS])
>  AC_SUBST([moduledir])
>  AC_SUBST([AMD_CFLAGS])
>
> -is386=false
> -
> -case $host_cpu in
> -  i*86)
> -       is386=true
> -       ;;
> -esac
> -
> -# Unset is386 if compiling for AMD64/EM64T
> -if test $is386 = true ; then
> -       AC_CHECK_DECLS([_LP64, __amd64__, amd64], [is386=false])
> -fi
> -
> -AM_CONDITIONAL([I386ARCH], [test $is386 = true])
> -
>  DRIVER_NAME=geode
>  AC_SUBST([DRIVER_NAME])
>
> --
> 1.7.4.1
>
> _______________________________________________
> Xorg-driver-geode mailing list
> Xorg-driver-geode at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-geode
>


More information about the Xorg-driver-geode mailing list