[Xorg-driver-geode] [PATCH 11/12] Remove -DPNL_SUP for the ztv driver

[Gaetan Nadon]

On Thu, 2011-11-17 at 21:57 +0200, Martin-Éric Racine wrote:

> Actually, both drivers support output to a Panel.  Plus, ztv input is
> for LX only.

Can you clarify why PNL_SUP is not used in the z4l.c and why it should
be defined in the makefile if not used?
In my patch series, ztv have it's own makefile (so z4l.c code only). 

Pardon my ignorance, I guess the ztv driver is an additional driver that
provides TV analog output. 
Some description in the README would be nice. Extensive googling did not
produce anything.

I can reunite ztv and geode in the same makefile but they will still
have different compiler options. I am determining which driver needs
which compiler options.

Sorry for all these patches, but the module has not been updated for
several years.

The more patches there the harder it is to review. I created a personal
repo you can browse and see the final result:

cgit.freedesktop.org/~gnadon/xf86-video-geode

which should be refreshed in an hour or so.

Thanks

> 
> 2011/11/17 Gaetan Nadon <memsize at videotron.ca>:
> > Only the gx driver provide such a panel.
> >
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  ztv/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/ztv/Makefile.am b/ztv/Makefile.am
> > index 4e7b587..670842b 100644
> > --- a/ztv/Makefile.am
> > +++ b/ztv/Makefile.am
> > @@ -1,7 +1,7 @@
> >
> >  if BUILD_ZTV
> >
> > -AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS) $(AMD_CFLAGS)
> > +AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS)
> >
> >  ztv_drv_la_LTLIBRARIES = ztv_drv.la
> >  ztv_drv_la_LDFLAGS = -module -avoid-version
> > --
> > 1.7.4.1
> >
> > _______________________________________________
> > Xorg-driver-geode mailing list
> > Xorg-driver-geode at lists.x.org
> > http://lists.x.org/mailman/listinfo/xorg-driver-geode
> >


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111117/f8dd4cc7/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111117/f8dd4cc7/attachment.pgp>