[Xorg-driver-geode] [PATCH 1/3] Mode Validation support on modeline in xorg.conf

Martin-Éric Racine q-funk at iki.fi
Wed Sep 29 06:37:47 PDT 2010


Merged in GIT.

On Wed, Sep 29, 2010 at 11:45 AM, Huang, FrankR <FrankR.Huang at amd.com> wrote:
> From: Frank Huang <frankr.huang at amd.com>
>
> *mode validation(lx_output_mode_valid) in geode driver should return
> MODE_OK for all modes filtered out by previous process in this function.
> Otherwise, new modelines(conf_modes) will be pruned by the Xserver function
> Xf86PruneInvalidModes. The result is that the user can not set any resolution
> they want. We comply with the code of ATI&&Intel mode_valid function to do this.
> *For the mode that can not be supported in geode driver, it is better to give
> the specific MODE_XXX(such as MODE_CLOCK_RANGE) instead of MODE_BAD.
>
> Signed-off-by: Frank Huang <frankr.huang at amd.com>
> ---
>  src/lx_output.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/lx_output.c b/src/lx_output.c
> index 413d376..aa7687c 100644
> --- a/src/lx_output.c
> +++ b/src/lx_output.c
> @@ -182,7 +182,7 @@ lx_output_mode_valid(xf86OutputPtr output, DisplayModePtr pMode)
>     if (pMode->type & (M_T_DRIVER | M_T_PREFERRED))
>         return MODE_OK;
>
> -    return MODE_BAD;
> +    return MODE_OK;
>  }
>
>  static Bool
> --
> 1.7.1
>
>
> _______________________________________________
> Xorg-driver-geode mailing list
> Xorg-driver-geode at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-geode
>



-- 
- maahanmuuttoasian ja ulkomaankaupan asiantuntija
- Suomen tutkimusverkoston jäsen, European Migration Network, MIGRI
- neuvottelukunnan jäsen 2009-2011, Otaniemi International Network, NEO-OTANIEMI
- käyttäjäraadin jäsen 2009-2013, Infopankki
- vierasblogaaja, Magma


More information about the Xorg-driver-geode mailing list