Mon Oct 11 18:12:11 PDT 2010
That is what we also want in geode driver.
WHAT I SUGGEST IS THAT WE JUST RETURN "MODE_OK" FOR THIS FUNCTION NOW.
> But the *correct* fix is to figure out why valid modes are being
> rejected. The patch you've posted is just a workaround for some other
> bug, and introduces more bugs in the process. That's why people are
> calling it wrong.
The reason why valid modes are being pruned is due to the MODE_BAD =
return in this function. In the following function =
xf86PruneInvalidModes, the modes that is not MODE_OK will be deleted. It =
is very clear. Just look at the code and you can get the answer. So I =
don't know "introduces more bugs" means what? What bug exactly will be =
introduced? If you take the example Ajax gave(1920x1440 160), we can add =
code to filter out that mode in the mode_valid function.
> Matthew Garrett | mjg59 at srcf.ucam.org
> Xorg-driver-geode mailing list
> Xorg-driver-geode at lists.x.org
More information about the Xorg-driver-geode