[Xorg-driver-geode] [PATCH v2] config: only build on i*86 host cpu.

[Gaetan Nadon]

On Tue, 2010-06-22 at 17:32 +0300, Martin-Éric Racine wrote:

> Gaetan,
> 
> There seems to be a confusion about two separate issues: the
> architecture on which Geode can be compiled, versus the architacture
> on which it can factually run.  As such, I'm not sure what your patch
> can accomplish. Would you care to explain?
> 

I want to skip building the driver on as many platforms as we can, where
we know it will fail to compile,
for the reasons I explained in the other post. 

I think the patch those that, perhaps a better message is required.


> Martin-Éric
> 
> On Tue, Jun 22, 2010 at 3:50 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > When doing full X.Org builds, many waste time investigating
> > compile errors, not knowing anything about Geode.
> >
> > The configuration will not abort, a warning message is issued
> > and no C code is compiled.
> >
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  Makefile.am  |    5 ++++-
> >  configure.ac |   12 ++++--------
> >  2 files changed, 8 insertions(+), 9 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 74e0bd3..adb0525 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -18,7 +18,10 @@
> >  #  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> >  #  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> >
> > -SUBDIRS = src
> > +if I386ARCH
> > +  SUBDIRS = src
> > +endif
> > +
> >  MAINTAINERCLEANFILES = ChangeLog INSTALL
> >  EXTRA_DIST = autogen.sh
> >
> > diff --git a/configure.ac b/configure.ac
> > index 36ee002..b456364 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -114,20 +114,16 @@ AC_SUBST([XORG_CFLAGS])
> >  AC_SUBST([moduledir])
> >  AC_SUBST([AMD_CFLAGS])
> >
> > -is386=false
> > -
> >  case $host_cpu in
> >   i*86)
> >        is386=true
> >        ;;
> > +  *)
> > +       AC_MSG_WARN([Geode only runs on 32 bit x86 instruction set architecture])
> >  esac
> >
> > -# Unset is386 if compiling for AMD64/EM64T
> > -if test $is386 = true ; then
> > -       AC_CHECK_DECLS([_LP64, __amd64__, amd64], [is386=false])
> > -fi
> > -
> > -AM_CONDITIONAL([I386ARCH], [test $is386 = true])
> > +# Only build Geode driver on 32 bit x86 instruction set architecture
> > +AM_CONDITIONAL([I386ARCH], [test "x$is386" = xtrue])
> >
> >  DRIVER_NAME=geode
> >  AC_SUBST([DRIVER_NAME])
> > --
> > 1.6.0.4
> >
> > Second edition.
> >
> > Updated the warning message
> > Updated the commit message
> >
> > I can push the patch if it's OK.
> >
> >
> >
> > _______________________________________________
> > Xorg-driver-geode mailing list
> > Xorg-driver-geode at lists.x.org
> > http://lists.x.org/mailman/listinfo/xorg-driver-geode
> >
> 
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20100622/b9c3202f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20100622/b9c3202f/attachment.pgp>