[Xorg-driver-geode] [PATCH v2] config: only build on i*86 host cpu.

Gaetan Nadon memsize at videotron.ca
Tue Jun 22 05:50:09 PDT 2010


When doing full X.Org builds, many waste time investigating
compile errors, not knowing anything about Geode.

The configuration will not abort, a warning message is issued
and no C code is compiled.

Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
---
 Makefile.am  |    5 ++++-
 configure.ac |   12 ++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 74e0bd3..adb0525 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -18,7 +18,10 @@
 #  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 #  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-SUBDIRS = src
+if I386ARCH
+  SUBDIRS = src
+endif
+
 MAINTAINERCLEANFILES = ChangeLog INSTALL
 EXTRA_DIST = autogen.sh
 
diff --git a/configure.ac b/configure.ac
index 36ee002..b456364 100644
--- a/configure.ac
+++ b/configure.ac
@@ -114,20 +114,16 @@ AC_SUBST([XORG_CFLAGS])
 AC_SUBST([moduledir])
 AC_SUBST([AMD_CFLAGS])
 
-is386=false
-
 case $host_cpu in
   i*86)
 	is386=true
 	;;
+  *)
+	AC_MSG_WARN([Geode only runs on 32 bit x86 instruction set architecture])
 esac
 
-# Unset is386 if compiling for AMD64/EM64T
-if test $is386 = true ; then
-	AC_CHECK_DECLS([_LP64, __amd64__, amd64], [is386=false])
-fi
-
-AM_CONDITIONAL([I386ARCH], [test $is386 = true])
+# Only build Geode driver on 32 bit x86 instruction set architecture
+AM_CONDITIONAL([I386ARCH], [test "x$is386" = xtrue])
 
 DRIVER_NAME=geode
 AC_SUBST([DRIVER_NAME])
-- 
1.6.0.4

Second edition.

Updated the warning message
Updated the commit message

I can push the patch if it's OK.





More information about the Xorg-driver-geode mailing list