[Xorg-driver-geode] Patches for rendering

Huang, FrankR FrankR.Huang at amd.com
Wed Jun 9 18:38:09 PDT 2010

Chris and Otavio,


            Thanks for your review of my patch.

            Owe to Mart’s patient help on how to use git and how to send the patch, I can give you the best format you guys can easily review. Special thanks for Mart.

            Now that the first patch is ok, I’ll put the other 6 patches to the xorg-driver-geode mail list today.

            Any feedback is welcome. The “Picky” for patch is necessary I think, so feel free to give me the suggestion. I understand that :-)






From: xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org [mailto:xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org] On Behalf Of Otavio Salvador
Sent: 2010年6月10日 1:39
To: Chris Ball
Cc: Huang, FrankR; xorg-driver-geode at lists.x.org
Subject: Re: [Xorg-driver-geode] Patches for rendering



On Wed, Jun 9, 2010 at 11:23 AM, Chris Ball <cjb at laptop.org> wrote:


  > On Wed, Jun 9, 2010 at 7:52 AM, Chris Ball <cjb at laptop.org> wrote:
  >> It's better to e-mail patches inline rather than attached, one
  >> e-mail per patch, so that it's easy to comment on specific parts
  >> of them.

  > Please, no.  Having to extract inline patches to commit to GIT is
  > a real PITA.

Sorry, I still disagree -- the Xorg community rejects attached patches
in general, so we shouldn't be recommending them here.  Inline patches
are much easier to review line-by-line.

As a compromise, if it helps, I'm happy to volunteer to do the
importing of Frank's patches into git.  It's just two commands
for me; save the whole mail into a file, and git-am thatfile.

Same hassle for me; so I offer help if need.

Otavio Salvador                  O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20100610/48d76abb/attachment.htm>

More information about the Xorg-driver-geode mailing list