[Xorg-driver-geode] Glyph rendering

[Mart Raudsepp]

On N, 2010-07-15 at 17:35 +0800, Huang, FrankR wrote:
> Jonathan,
> 
> 	That's Mart's findings. I am not sure if he got it from debug or from code.
> 	From my debug, only three rendering requests for "x11perf -aa10text" are met in lx_check_composite. That three requests are still:
> 	1)Op:PictOpAdd, Src:PICT_a8r8g8b8 Mask:0 Dest:PICT_a8


I got it from code and Michel. The source is just a pointer at the code
I was looking at, and I didn't track that all the way down to its
creation, as Michel said that source should commonly be PICT_a8 there.

The first checks destination is definitely PICT_a8 on first try.

The source to CheckComposite call comes from exaGlyphs second argument,
which seems to be the src PICTURE passed from CompositeGlyphs{8,16,32}.
This appears to be the 1x1 pixel with repeat set solid color...
Why would we try to PictOpAdd that solid color to a PICT_a8 glyph alpha
masks cache to decide if glyph mask copy to glyph cache is possible?
Later the PictOpAdd operation is done with buffer->mask as the source
instead..

Is my analysis correct and there's a bug like that in Xserver commit
346e7152?

I guess it should be pretty easy to add a printout of pSrc format right
before that CheckComposite check in exaGlyphs() to verify.


Regards,
Mart


> 	2)Op:PictOpAdd, Src:PICT_a8 Mask:0 Dest:PICT_a8r8g8b8
> 	3)Op:PictOpOver, Src:PICT_a8r8g8b8 Mask:PICT_a8r8g8b8 Dst:PICT_r5g6b5
> 
> 
> Thanks,
> Frank
> 
> 
> 
> -----Original Message-----
> From: Jonathan Morton [mailto:jonathan.morton at movial.com] 
> Sent: 2010?7?15? 17:28
> To: Huang, FrankR
> Cc: Mart Raudsepp; xorg-driver-geode at lists.x.org; michel at daenzer.net
> Subject: RE: [Xorg-driver-geode] Glyph rendering
> 
> On Thu, 2010-07-15 at 17:22 +0800, Huang, FrankR wrote:
> > But I have not found this requirement(Add A8->A8) from my debug?
> 
> Are you looking in PrepareComposite or CheckComposite?  Someone
> mentioned a test which was hard-rejecting all A8->A8 operations, and
> that could well be in CheckComposite.
>