[Xorg-driver-geode] [PATCH] Revert "Added FAQ aboutminimal memory requirements to rotate screen in README."

[Cui, Hunk]

Also agree with Mart's advice, Don't encourage users to increase Graphic memory, May be this is a misunderstanding. Mitch have used the former Rotate patch to validate the operation based on the 14Mb, it also normally do Rotate operation, So this is No-Ack.

Thanks,
Hunk Cui

-----Original Message-----
From: xorg-driver-geode-bounces+hunk.cui=amd.com at lists.x.org [mailto:xorg-driver-geode-bounces+hunk.cui=amd.com at lists.x.org] On Behalf Of Mart Raudsepp
Sent: Monday, July 12, 2010 1:07 AM
To: xorg-driver-geode at lists.x.org
Subject: Re: [Xorg-driver-geode] [PATCH] Revert "Added FAQ aboutminimal memory requirements to rotate screen in README."

On P, 2010-07-11 at 19:58 +0300, Martin-Éric Racine wrote:
> No-Ack.  I don't recall us ever reaching a conclusion that having less
> than 32MB under X >>1.6 would produce successful rotations. Anyhow, if
> we're gonna correct this FAQ item, I'd rather us fix the minimal
> amount of RAM needed for a successful rotation than revert this whole
> change.

We should not document bugs as FAQ's, even if it works with 32MB, which
no-one has tested to be the case to my knowledge. Or has, and found it
to not be working with current GIT state.
The case that did work with 32MB was when coupled with an interim patch
from Hunk. We do not have that patch in GIT repository, nor do we intend
to include that patch as far as I'm concerned.
Whereas with xorg-server-1.6 rotation works just fine with 14MB, as
evidenced by this XO-1 right next to me, running xserver-1.6.

It is not a good idea to encourage users to increase their video memory
for no good reason, or due to a bug, only so that they forget and leave
this setting permanently to 32MB+ video memory, long after we have fixed
the real cause in 2.11.9 or 2.11.10 release.

Regards,
Mart Raudsepp


> On Sun, Jul 11, 2010 at 7:52 PM, Mart Raudsepp <leio at gentoo.org> wrote:
> > This reverts commit b47d77360cb428d8892beb93789c83dfa681b26f.
> >
> > There is no basis on the claims about 32MB minimum video memory for screen
> > rotation. The other changes that reorganize some options under Common options
> > can be redone in a proper atomic change of that purpose.
> > ---
> >  README |   31 ++++++++++++++-----------------
> >  1 files changed, 14 insertions(+), 17 deletions(-)
> >
> > diff --git a/README b/README
> > index 7c49fa7..a74cf73 100644
> > --- a/README
> > +++ b/README
> > @@ -66,12 +66,6 @@ because it utilizes the new common DDC probing libraries from X.Org.
> >
> >  = FAQ =
> >
> > -Q: Why doesn't screen rotation work?
> > -
> > -A: Make sure that at least 32MB of memory is reserved for video operation
> > -   (check the BIOS settings), otherwise rotation will fail and display an
> > -   "Out of memory" error message in the X.org log.
> > -
> >  Q: Why doesn't this GEODE driver work at WXGA (wide screen) resolutions?
> >
> >  A: Make sure that TFT Panel support is disabled in the BIOS settings,
> > @@ -116,24 +110,27 @@ EndSection
> >
> >  The following options may be added to the section:
> >
> > -== Common options ==
> > +== GX ==
> >
> > -FBSize: Specify the size of the video space (in bytes)
> > -NoAccel: Disable hardware assisted acceleration
> > -NoCompression: Disable video bandwidth compression
> > -NoPanel: Disable panel support
> > -Rotate: Select a orientation to start with - LEFT, INVERT, CCW
> >  SWCursor: Enable software cursors (essentially disabling HW cursor support)
> > -
> > -== GX-specific options ==
> > -
> > +NoCompression: Disable video bandwidth compression
> > +NoAccel: Disable hardware assisted acceleration
> >  AccelMethod: "XAA" (default) or "EXA"
> > -PanelGeometry: Specify the geometry of the attached panel ("<width>x<height>")
> > +Rotate: Select a orientation to start with - LEFT, INVERT, CCW
> > +NoPanel: Disable panel support
> >  OSMImageBuffers: Set the number of image buffers (XAA only)
> >  OSMColorExpBuffers: Set the number of color expansion buffers (XAA only)
> > +FBSize: Specify the size of the video space (in bytes)
> > +PanelGeometry: Specify the geometry of the attached panel ("<width>x<height>")
> >
> > -== LX-specific options ==
> > +== LX ==
> >
> > +SWCursor: Enable software cursors (essentially disabling HW cursor support)
> > +NoCompression: Disable video bandwidth compression
> > +NoAccel: Disable hardware assisted acceleration
> > +Rotate: Select a orientation to start with - LEFT, INVERT, CCW
> > +NoPanel: Disable panel support
> >  ExaScratch: Specify the amount of extra EXA scratch buffer (in bytes)
> > +FBSize: Specify the size of the video space (in bytes)
> >
> >  = EOF =
> > --
> > 1.6.1.3
> >
> > _______________________________________________
> > Xorg-driver-geode mailing list
> > Xorg-driver-geode at lists.x.org
> > http://lists.x.org/mailman/listinfo/xorg-driver-geode
> >
> 
> 
> 

_______________________________________________
Xorg-driver-geode mailing list
Xorg-driver-geode at lists.x.org
http://lists.x.org/mailman/listinfo/xorg-driver-geode