[Xorg-driver-geode] [PATCH 3/4] GX: refactory mode validation code to be easier to ready

Otavio Salvador otavio at ossystems.com.br
Mon Jan 25 15:34:16 PST 2010


Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
---
 src/gx_driver.c |   35 ++++++++++++++++++-----------------
 1 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/gx_driver.c b/src/gx_driver.c
index 7ff5418..1c25e1a 100644
--- a/src/gx_driver.c
+++ b/src/gx_driver.c
@@ -1412,7 +1412,7 @@ GXValidMode(int scrnIndex, DisplayModePtr pMode, Bool Verbose, int flags)
 {
     ScrnInfoPtr pScrni = xf86Screens[scrnIndex];
     GeodeRec *pGeode = GEODEPTR(pScrni);
-    int p, ret;
+    int p;
     int custom = 0;
 
     if (pGeode->Panel)
@@ -1422,23 +1422,24 @@ GXValidMode(int scrnIndex, DisplayModePtr pMode, Bool Verbose, int flags)
 
     /* Use the durango lookup for !custom modes */
 
-    if (!custom) {
-	if (pGeode->Panel) {
-	    if (pMode->CrtcHDisplay > pGeode->PanelX ||
-		pMode->CrtcVDisplay > pGeode->PanelY ||
-		gfx_is_panel_mode_supported(pGeode->PanelX, pGeode->PanelY,
-		    pMode->CrtcHDisplay, pMode->CrtcVDisplay,
-		    pScrni->bitsPerPixel) < 0) {
-
-		return MODE_BAD;
-	    }
-	}
+    if (!custom && pGeode->Panel) {
+        if (pMode->CrtcHDisplay > pGeode->PanelX ||
+            pMode->CrtcVDisplay > pGeode->PanelY ||
+            gfx_is_panel_mode_supported(pGeode->PanelX,
+                                        pGeode->PanelY,
+                                        pMode->CrtcHDisplay,
+                                        pMode->CrtcVDisplay,
+                                        pScrni->bitsPerPixel) < 0) {
+
+            return MODE_BAD;
+        }
+    }
 
-	ret = gfx_is_display_mode_supported(pMode->CrtcHDisplay,
-	    pMode->CrtcVDisplay,
-	    pScrni->bitsPerPixel, GeodeGetRefreshRate(pMode));
-	if (ret < 0)
-	    return MODE_BAD;
+    if (gfx_is_display_mode_supported(pMode->CrtcHDisplay,
+                                      pMode->CrtcVDisplay,
+                                      pScrni->bitsPerPixel,
+                                      GeodeGetRefreshRate(pMode)) < 0) {
+        return MODE_BAD;
     }
 
     if (pMode->Flags & V_INTERLACE)
-- 
1.6.6.80.g2df32



More information about the Xorg-driver-geode mailing list