[Xorg-driver-geode] [PATCH] Rectify lx_display.c outstanding compiler warnings

Cui, Hunk Hunk.Cui at amd.com
Mon Aug 9 03:03:23 PDT 2010


From: Hunk Cui <Hunk.Cui at amd.com>

*Correct the type of LXAllocShadow from Bool to static Bool.

Signed-off-by: Hunk Cui <Hunk.Cui at amd.com>
---
 src/lx_display.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lx_display.c b/src/lx_display.c
index 4f7c4ed..ae1d39f 100644
--- a/src/lx_display.c
+++ b/src/lx_display.c
@@ -368,7 +368,7 @@ lx_crtc_gamma_set(xf86CrtcPtr crtc, CARD16 * red,
CARD16 * green,
      * of card space is returned.
      */
 
-Bool
+static Bool
 LXAllocShadow(ScrnInfoPtr pScrni, int size)
 {
     GeodeRec *pGeode = GEODEPTR(pScrni);
@@ -390,6 +390,7 @@ LXAllocShadow(ScrnInfoPtr pScrni, int size)
     }
 
     pScrni->fbOffset = pGeode->shadowArea->offset;
+    return TRUE;
 }
 
 static void *
@@ -402,9 +403,8 @@ lx_crtc_shadow_allocate(xf86CrtcPtr crtc, int width,
int height)
     rpitch = pScrni->displayWidth * (pScrni->bitsPerPixel / 8);
     size = rpitch * height;
 
-    LXAllocShadow(pScrni, size); /* Allocate shadow memory */
-
-    if (pGeode->shadowArea->offset == NULL) {
+    /* Allocate shadow memory */
+    if (LXAllocShadow(pScrni, size) == FALSE) {
 	xf86DrvMsg(pScrni->scrnIndex, X_ERROR,
 	    "Couldn't allocate the shadow memory for rotation\n");
 	xf86DrvMsg(pScrni->scrnIndex, X_ERROR,
-- 
1.7.1




More information about the Xorg-driver-geode mailing list