[Xorg-driver-geode] outstanding compiler warnings onxf86-video-geode

[Huang, FrankR]

See below comments.

Thanks,
Frank

> -----Original Message-----
> From: xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org
> [mailto:xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org] On
> Behalf Of Martin-éric Racine
> Sent: 2010年8月7日 0:47
> To: Geode Mailing List
> Subject: Re: [Xorg-driver-geode] outstanding compiler warnings onxf86-
> video-geode
> 
> 2010/8/6 Martin-Éric Racine <q-funk at iki.fi>:
> > 2010/8/6 Martin-Éric Racine <q-funk at iki.fi>:
> >> When running distcheck on our Geode GIT tree, I found that the
> >> following compiler warnings still remain:
> >>
> >> 1) when compiling panel.lo:
> >>
> >>  CC     panel.lo
> >> In file included from ../../src/panel/pnl_init.c:64,
> >>                 from ../../src/panel.c:56:
> >> ../../src/panel/gx2_9211.c: In function ‘set_Redcloud_92xx_mode_params’:
> >> ../../src/panel/gx2_9211.c:199: warning: passing argument 3 of
> >> ‘gfx_msr_read’ from incompatible pointer type
> >> ../../src/gfx/gfx_rtns.h:132: note: expected ‘struct QQ_WORD *’ but
> >> argument is of type ‘struct Q_WORD *’
> >> ../../src/panel/gx2_9211.c:206: warning: passing argument 3 of
> >> ‘gfx_msr_write’ from incompatible pointer type
> >> ../../src/gfx/gfx_rtns.h:134: note: expected ‘struct QQ_WORD *’ but
> >> argument is of type ‘struct Q_WORD *’
> >>
[Frank] change the type from Q_WORD to QQ_WORD

> >> 2) when compiling z4l.lo:
> >>
> >>  CC     z4l.lo
> >> ../../src/z4l.c: In function ‘Z4lSetPortAttribute’:
> >> ../../src/z4l.c:1187: warning: initialization discards qualifiers from
> >> pointer target type
> >> ../../src/z4l.c: In function ‘Z4lGetPortAttribute’:
> >> ../../src/z4l.c:1248: warning: initialization discards qualifiers from
> >> pointer target type 
[Frank] the type should be "const char"

> >>
> >> I was wondering if we could fix these before producing the Geode 2.11.9
> release?
[Frank] I'll release the patch later for these warnings.

> >>
> >> Cheers!
> >> Martin-Éric
> >
> >
> > After applying Hunk's two patches from 12th July:
> >
> > lx_display.c:372: warning: no previous prototype for ‘LXAllocShadow’
> > lx_display.c: In function ‘lx_crtc_shadow_allocate’:
> > lx_display.c:407: warning: comparison between pointer and integer
> > lx_display.c: In function ‘LXAllocShadow’:
> > lx_display.c:393: warning: control reaches end of non-void function
> >
> > Martin-Éric
> 
[Frank] Hunk is working on that to eliminate these warnings with his patch.

> Please see http://pastie.org/1079903 for a log of remaining compiler
> messages.
> 
> Martin-Éric
> _______________________________________________
> Xorg-driver-geode mailing list
> Xorg-driver-geode at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-geode