[Xorg-driver-geode] [PATCH 1/3] [GL]X: use 24bit depth by default

[Martin-Éric Racine]

Actually, setting 32-bit as the default is the wrong approach:

1) it is only a kludge for broken toolkits e.g. XFCE libraries.
2) it eats a lot of memory that might not be available on some
hardware (remember: we have an UMA architecture).

That's why we had agreed with Jordan to use 16-bit as the default.

On Thu, Sep 10, 2009 at 12:34 AM, Otavio
Salvador<otavio at ossystems.com.br> wrote:
> It has been found that 24/32bit depth work-around few issues; due
> that, we set it as default for now.
>
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
>  src/gx_driver.c |    2 +-
>  src/lx_driver.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gx_driver.c b/src/gx_driver.c
> index 7ff5418..6f5767d 100644
> --- a/src/gx_driver.c
> +++ b/src/gx_driver.c
> @@ -464,7 +464,7 @@ GXPreInit(ScrnInfoPtr pScrni, int flags)
>     /* Fill in the monitor information */
>     pScrni->monitor = pScrni->confScreen->monitor;
>
> -    if (!xf86SetDepthBpp(pScrni, 16, 16, 16, Support24bppFb | Support32bppFb))
> +    if (!xf86SetDepthBpp(pScrni, 24, 16, 32, Support24bppFb | Support32bppFb))
>        return FALSE;
>
>     switch (pScrni->depth) {
> diff --git a/src/lx_driver.c b/src/lx_driver.c
> index 08d1fdd..79ec15c 100644
> --- a/src/lx_driver.c
> +++ b/src/lx_driver.c
> @@ -331,7 +331,7 @@ LXPreInit(ScrnInfoPtr pScrni, int flags)
>     /* Fill in the monitor information */
>     pScrni->monitor = pScrni->confScreen->monitor;
>
> -    if (!xf86SetDepthBpp(pScrni, 16, 16, 16, Support24bppFb | Support32bppFb))
> +    if (!xf86SetDepthBpp(pScrni, 24, 16, 32, Support24bppFb | Support32bppFb))
>        return FALSE;
>
>     switch (pScrni->depth) {
> --
> 1.6.3.3.385.g60647
>
> _______________________________________________
> Xorg-driver-geode mailing list
> Xorg-driver-geode at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-geode
>