[Xorg-driver-geode] Startup crash on OLPC.

Chris Ball cjb at laptop.org
Sat Feb 14 21:07:02 PST 2009


Hi Mart,

> diff --git a/src/lx_exa.c b/src/lx_exa.c
> index 5d636ea..f6eeb65 100644
> --- a/src/lx_exa.c
> +++ b/src/lx_exa.c
> @@ -564,7 +564,11 @@ lx_check_composite(int op, PicturePtr pSrc, PicturePtr pMsk, PicturePtr pDst)
>  	return FALSE;
>      }
>  
> -    /* Keep an eye out for rotation transforms - those we can
> +    /* We don't support any mask transforms */
> +    if (pMsk->transform)
> +	return FALSE;
> +
> +    /* Keep an eye out for source rotation transforms - those we can
>       * do something about */
>  
>      exaScratch.rotate = RR_Rotate_0;

This commit (7c278551c79d7a5898c627341f58fad59b7ae20d) causes a segfault
at startup on OLPC, as pMsk is sometimes NULL:

Program received signal SIGSEGV, Segmentation fault.
0xb79ad639 in lx_check_composite (op=3, pSrc=0x9bd7898, pMsk=0x0,
    pDst=0x9bd78f0) at lx_exa.c:568

I'll push the obvious fix (pMsk && pMsk->transform), and make a release.

Thanks,

- Chris.
-- 
Chris Ball   <cjb at laptop.org>


More information about the Xorg-driver-geode mailing list