<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - xserver-1.18.2 uses one core fully with dri3"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94596#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - xserver-1.18.2 uses one core fully with dri3"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94596">bug 94596</a>
from <span class="vcard"><a class="email" href="mailto:lordheavym@gmail.com" title="Laurent carlier <lordheavym@gmail.com>"> <span class="fn">Laurent carlier</span></a>
</span></b>
<pre>Bisecting result:
e457e93e5d33cbec387e40051fbabf6cf76d6af3 is the first bad commit
commit e457e93e5d33cbec387e40051fbabf6cf76d6af3
Author: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com">michel.daenzer@amd.com</a>>
Date: Wed Feb 24 16:52:59 2016 +0900
present: Only requeue if target MSC is not reached after an unflip
While present_pixmap decrements target_msc by 1 for present_queue_vblank,
it leaves the original vblank->target_msc intact. So incrementing the
latter for requeueing resulted in the requeued presentation being
executed too late.
Also, no need to requeue if the target MSC is already reached.
This further reduces stutter when a popup menu appears on top of a
flipping fullscreen window.
Reviewed-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Signed-off-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com">michel.daenzer@amd.com</a>>
(cherry picked from commit b4ac7b142fa3c536e9b283cfd34b94d82c03aac6)
:040000 040000 ed8bcba1d57c5f2070241b926eb60abcb15dc19f
0a73bffafa12376ef064352c520e962e3c7e351e M present
Bisect log:
git bisect start
# good: [23e60f917a5af652cd83b8a3a9951c79838721b3] xserver 1.18.1
git bisect good 23e60f917a5af652cd83b8a3a9951c79838721b3
# bad: [93d4224ccf3dee5a51815a66f76c905450419b50] xserver 1.18.2
git bisect bad 93d4224ccf3dee5a51815a66f76c905450419b50
# bad: [c1eb12f89c2391cd99a834da6b342f104da1eb5c] xwin: Update to XRANDR 1.2
internal interface to ensure an output is reported by XRANDR
git bisect bad c1eb12f89c2391cd99a834da6b342f104da1eb5c
# good: [68bd172432de069aa242d21b3af505867417ae45] glamor: Reuse the
glamor_program_alpha_* enums for Render.
git bisect good 68bd172432de069aa242d21b3af505867417ae45
# good: [29d1c5a8e4127d5fd1a0d41f8e1474e9dfdb9638] randr: Send ConfigNotify
when manual monitor list changes
git bisect good 29d1c5a8e4127d5fd1a0d41f8e1474e9dfdb9638
# good: [eb5108b87017128f394ae31b5b7cd85dd8819bca] present: Requeue if flip
driver hook fails and target MSC not reached
git bisect good eb5108b87017128f394ae31b5b7cd85dd8819bca
# bad: [1e143cff16835dd69559ca5646f313dad3db75ab] xwin: Improve handling of
no-decoration motif hint
git bisect bad 1e143cff16835dd69559ca5646f313dad3db75ab
# bad: [f0c2a3527797cf2bfbfa4697c294ae087c1e4423] xwin: XGetWMNormalHints()
returns non-zero on success
git bisect bad f0c2a3527797cf2bfbfa4697c294ae087c1e4423
# bad: [e457e93e5d33cbec387e40051fbabf6cf76d6af3] present: Only requeue if
target MSC is not reached after an unflip
git bisect bad e457e93e5d33cbec387e40051fbabf6cf76d6af3
# first bad commit: [e457e93e5d33cbec387e40051fbabf6cf76d6af3] present: Only
requeue if target MSC is not reached after an unflip</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>