[PATCH xf86-video-amdgpu 1/3] Don't advertise any PRIME offloading capabilities without acceleration

[Michel Dänzer]

On 16.02.2016 02:12, Richard Wilbur wrote:
>> -               if (value & DRM_PRIME_CAP_EXPORT) {
>> -                       pScrn->capabilities |= RR_Capability_SourceOutput;
>> -                       if (info->use_glamor && info->dri2.available)
>> -                               pScrn->capabilities |= RR_Capability_SinkOffload;
>> -               }
>> -               if (value & DRM_PRIME_CAP_IMPORT) {
>> -                       pScrn->capabilities |= RR_Capability_SinkOutput;
>> -                       if (info->use_glamor && info->dri2.available)
>> -                               pScrn->capabilities |= RR_Capability_SourceOffload;
>> -               }
>> +               if (value & DRM_PRIME_CAP_EXPORT)
>> +                       pScrn->capabilities |= RR_Capability_SourceOutput | RR_Capability_SinkOffload;
>> +               if (value & DRM_PRIME_CAP_IMPORT)
>> +                       pScrn->capabilities |= RR_Capability_SinkOutput | RR_Capability_SourceOffload;
>>         }
>>  #endif
>>  }
> 
> I see the factoring of if (info->use_glamor) out of setting the
> capabilities flags, but I'm wondering whether 'info->dri2.available'
> still matters?

info->use_glamor currently can't be TRUE if info->dri2.available is
FALSE, that test was redundant here.

Thanks for taking a look.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer