[PATCH 03/14] Add DRM event queue helpers

[Michel Dänzer]

On 12.03.2015 15:55, Richard Wilbur wrote:
> On Thu, Mar 12, 2015 at 12:10 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> diff --git a/src/radeon_drm_queue.c b/src/radeon_drm_queue.c
>> new file mode 100644
>> index 0000000..7b7fd06
>> --- /dev/null
>> +++ b/src/radeon_drm_queue.c
> [...]
>> +struct radeon_drm_queue {
>> +    struct xorg_list list;
>> +    uint64_t id;
>> +    void *data;
>> +    ClientPtr client;
>> +    ScrnInfoPtr scrn;
>> +    radeon_drm_handler_proc handler;
>> +    radeon_drm_abort_proc abort;
>> +};
>> +
>> +static int radeon_drm_queue_refcnt;
>> +static struct xorg_list radeon_drm_queue;
> 
> Seems this would be clearer if the type 'struct radeon_drm_queue'
> wasn't the same name as a subsequent variable in the same scope.
> Maybe change the type name to something like 'struct
> radeon_drm_queue_entry'?

Good suggestion, thanks! Changed for v2.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer