[PATCH 1/2] Remove unused local variable pRADEONEnt

Dave Airlie airlied at gmail.com
Thu Jul 30 03:00:22 PDT 2015


On 30 July 2015 at 17:00, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> ../../src/radeon_probe.c: In function 'radeon_get_scrninfo':
> ../../src/radeon_probe.c:157:22: warning: variable 'pRADEONEnt' set but not used [-Wunused-but-set-variable]
>          RADEONEntPtr pRADEONEnt;
>                       ^
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

For both,

Reviewed-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/radeon_probe.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/radeon_probe.c b/src/radeon_probe.c
> index f81ed13..65cf0c9 100644
> --- a/src/radeon_probe.c
> +++ b/src/radeon_probe.c
> @@ -154,7 +154,6 @@ radeon_get_scrninfo(int entity_num, void *pci_dev)
>       */
>      {
>          DevUnion    *pPriv;
> -        RADEONEntPtr pRADEONEnt;
>
>          xf86SetEntitySharable(entity_num);
>
> @@ -166,12 +165,8 @@ radeon_get_scrninfo(int entity_num, void *pci_dev)
>
>         xf86SetEntityInstanceForScreen(pScrn, pEnt->index, xf86GetNumEntityInstances(pEnt->index) - 1);
>
> -        if (!pPriv->ptr) {
> +        if (!pPriv->ptr)
>              pPriv->ptr = xnfcalloc(sizeof(RADEONEntRec), 1);
> -            pRADEONEnt = pPriv->ptr;
> -        } else {
> -            pRADEONEnt = pPriv->ptr;
> -        }
>      }
>
>      free(pEnt);
> --
> 2.1.4
>
> _______________________________________________
> xorg-driver-ati mailing list
> xorg-driver-ati at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-ati


More information about the xorg-driver-ati mailing list